Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Rails/WhereEquals aware of safe navigation operator #1201

Closed
ydakuka opened this issue Dec 3, 2023 · 0 comments
Closed

Make Rails/WhereEquals aware of safe navigation operator #1201

ydakuka opened this issue Dec 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ydakuka
Copy link

ydakuka commented Dec 3, 2023

Describe the solution you'd like

# bad
def my_method
  obj&.where('name = ?', 'Gabe')
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.58.0 (using Parser 3.2.2.4, rubocop-ast 1.30.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
@koic koic added the enhancement New feature or request label Dec 4, 2023
koic added a commit to koic/rubocop-rails that referenced this issue Dec 5, 2023
@koic
Make some cops aware of safe navigation operator
5eb526a 
Fixes rubocop#1191, rubocop#1192, rubocop#1193, rubocop#1194, rubocop#1196, rubocop#1197, rubocop#1201, and rubocop#1202.

This PR makes `Rails/ActiveSupportAliases`, `Rails/FindBy`, `Rails/FindById`, `Rails/Inquiry`,
`Rails/Pick` `Rails/PluckId`, `Rails/PluckInWhere`, `Rails/WhereEquals`, `Rails/WhereExists`,
and `Rails/WhereNot` cops aware of safe navigation operator.
@koic koic mentioned this issue Dec 5, 2023
Merged
9 tasks
koic added a commit to koic/rubocop-rails that referenced this issue Dec 5, 2023
@koic
Make some cops aware of safe navigation operator
3ef1c5b 
Fixes rubocop#1191, rubocop#1192, rubocop#1193, rubocop#1194, rubocop#1196, rubocop#1197, rubocop#1201, and rubocop#1202.

This PR makes `Rails/ActiveSupportAliases`, `Rails/FindBy`, `Rails/FindById`, `Rails/Inquiry`,
`Rails/Pick` `Rails/PluckId`, `Rails/PluckInWhere`, `Rails/WhereEquals`, `Rails/WhereExists`,
and `Rails/WhereNot` cops aware of safe navigation operator.
koic added a commit to koic/rubocop-rails that referenced this issue Dec 13, 2023
@koic
Make some cops aware of safe navigation operator
43d7d73 
Fixes rubocop#1191, rubocop#1192, rubocop#1193, rubocop#1194, rubocop#1196, rubocop#1197, rubocop#1201, and rubocop#1202.

This PR makes `Rails/ActiveSupportAliases`, `Rails/FindBy`, `Rails/FindById`, `Rails/Inquiry`,
`Rails/Pick` `Rails/PluckId`, `Rails/PluckInWhere`, `Rails/WhereEquals`, `Rails/WhereExists`,
and `Rails/WhereNot` cops aware of safe navigation operator.
koic added a commit to koic/rubocop-rails that referenced this issue Dec 15, 2023
@koic
Make some cops aware of safe navigation operator
7c672a0 
Fixes rubocop#1191, rubocop#1192, rubocop#1193, rubocop#1194, rubocop#1196, rubocop#1197, rubocop#1201, and rubocop#1202.

This PR makes `Rails/ActiveSupportAliases`, `Rails/FindBy`, `Rails/FindById`, `Rails/Inquiry`,
`Rails/Pick` `Rails/PluckId`, `Rails/PluckInWhere`, `Rails/WhereEquals`, `Rails/WhereExists`,
and `Rails/WhereNot` cops aware of safe navigation operator.
@koic koic closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koic @ydakuka