-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive in Rails/ReversibleMigration #476
Labels
bug
Something isn't working
Comments
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
May 4, 2021
Fixes rubocop#476. This PR fixes a false positive for `Rails/ReversibleMigratin` when using `drop_table` with symbol proc.
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
May 4, 2021
Fixes rubocop#476. This PR fixes a false positive for `Rails/ReversibleMigration` when using `drop_table` with symbol proc.
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
May 4, 2021
Fixes rubocop#476. This PR fixes a false positive for `Rails/ReversibleMigration` when using `drop_table` with symbol proc.
9 tasks
koic
added a commit
that referenced
this issue
May 5, 2021
…rsible_migration [Fix #476] Fix a false positive for `Rails/ReversibleMigration`
Thank you for a quick resolution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
Given the following migration
I expect Rubocop to not give any warnings, since this is a valid reversible migration.
If we try to do this as a block instead (which Rails/ReversibleMigration wants)
we will run into the Style/SymbolProc cop instead.
Actual behavior
Rubocop gives a Rails/ReversibleMigration warning.
Steps to reproduce the problem
See simple example above.
RuboCop version
The text was updated successfully, but these errors were encountered: