We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/puma.rb
Rails/ContentTag
tag "dynamic-#{interpolated}-string"
For context: https://puma.io/puma/Puma/DSL.html#tag-instance_method
tag.dynamic-#{interpolated}-string
env_cfg = ENV.fetch("RAILS_ENV") { "development" } tag "app-name-#{env_cfg}"
rubocop -a --only Rails/ContentTag
$ [bundle exec] rubocop -V 1.25.1 (using Parser 3.1.0.0, rubocop-ast 1.15.1, running on ruby 2.6.8 x86_64-linux) - rubocop-performance 1.13.2 - rubocop-rails 2.13.2
The text was updated successfully, but these errors were encountered:
[Fix rubocop#636] Fix a false positive for Rails/ContentTag
5995b4f
Fixes rubocop#636. This PR fixes a false positive for `Rails/ContentTag` when using `tag` method in config/puma.rb.
Merge pull request #637 from koic/fix_a_false_positive_for_rails_cont…
da9d225
…ent_tag [Fix #636] Fix a false positive for `Rails/ContentTag`
Successfully merging a pull request may close this issue.
Expected behavior
config/puma.rb
is never a rails view or helper and should be ignored byRails/ContentTag
tag "dynamic-#{interpolated}-string"
, even if it were in a rails viewFor context: https://puma.io/puma/Puma/DSL.html#tag-instance_method
Actual behavior
config/puma.rb
is reported and autocorrected byRails/ContentTag
tag "dynamic-#{interpolated}-string"
intotag.dynamic-#{interpolated}-string
Steps to reproduce the problem
config/puma.rb
:rubocop -a --only Rails/ContentTag
RuboCop version
The text was updated successfully, but these errors were encountered: