Add cop Rails/AcceptsNestedAttributesForUpdateOnly
#1035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cop
Rails/AcceptsNestedAttributesForUpdateOnly
.This cop looks for
accepts_nested_attributes_for
attributes writers that don't specify an:update_only
option.The default value for
:update_only
isfalse
, meaning that a new nested model will be created unless the ID of the existing model is explicitly provided in the attributes. This is not always the desired behavior, so I think a cop that forces an explicit decision regarding which value:update_only
should take would be a valuable addition.Implementation-wise, this cop is based on the existing
Rails/HasOneHasManyDependent
cop that does something very similar (enforce an explicit:dependent
value forhas_one
andhas_many
associations).Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.