Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #368] Add DelegatePrivate cop #1057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

povilasjurcys
Copy link

@povilasjurcys povilasjurcys commented Aug 2, 2023

This PR solves #368 issue by adding DelegatePrivate cop. This cop ensures that private: true is used when delegating methods in private is skipped in public scope. Here are more cases:

# bad
class Foo
  def bar=Bar.new

  private

  delegate :baz, to: :bar
end

# bad
class Foo
  delegate :baz, to: :bar, private: true

  def bar=Bar.new
end

# good
class Foo
  def bar=Bar.new

  private

  delegate :baz, to: :bar, private: true
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@povilasjurcys povilasjurcys force-pushed the add_delegate_private_cop branch 3 times, most recently from 3362967 to 72401e5 Compare August 2, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant