Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1075] Add new Rails/SelectMap cop #1102

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

koic
Copy link
Member

@koic koic commented Sep 2, 2023

Resolves #1075.

This PR adds new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). These can be replaced with pluck(:column_name).
There also should be some performance improvement since it skips instantiating the model class for matches.

# bad
Model.select(:column_name).map(&:column_name)

# good
Model.pluck(:column_name)

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@vlad-pisanov
Copy link
Contributor

This should be marked unsafe, since the model might overload the attribute getter; also the model's after_initialize hooks are skipped when pluck is used.

Resolves rubocop#1075.

This PR adds new `Rails/SelectMap` cop that checks for uses of `select(:column_name)` with `map(&:column_name)`.
These can be replaced with `pluck(:column_name)`.
There also should be some performance improvement since it skips instantiating the model class for matches.

```ruby
# bad
Model.select(:column_name).map(&:column_name)

# good
Model.pluck(:column_name)
```
@koic koic force-pushed the add_new_rails_select_map_cop branch from 52a4993 to 5043655 Compare September 4, 2023 03:52
@koic koic merged commit 1bcba4d into rubocop:master Sep 7, 2023
4 checks passed
@koic koic deleted the add_new_rails_select_map_cop branch September 7, 2023 16:16
@Earlopain
Copy link
Contributor

Cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cop idea: Prefer pluck(:column) over select(:column).map(&:column)
3 participants