Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1121] Fix an error for Rails/SelectMap #1122

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

koic
Copy link
Member

@koic koic commented Sep 15, 2023

Fixes #1121.

This PR fixes an error for Rails/SelectMap when using select(:column_name).map(&:column_name) without receiver model.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#1121.

This PR fixes an error for `Rails/SelectMap`
when using `select(:column_name).map(&:column_name)` without receiver model.
@koic koic merged commit d3117ff into rubocop:master Sep 21, 2023
4 checks passed
@koic koic deleted the fix_an_error_for_rails_select_map branch September 21, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurs in Rails/SelectMap when select receiver is implicit
1 participant