Fix a false positive for Rails/RedundantActiveRecordAllMethod
#1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_rails_redundant_active_record_all_method
branch
2 times, most recently
from
60ccbef
to
343f8fc
Compare
koic
changed the title
RedundantActiveRecordAllMethodRails/RedundantActiveRecordAllMethod
koic
force-pushed
the
fix_a_false_positive_for_rails_redundant_active_record_all_method
branch
from
343f8fc
to
c09deca
Compare
|
May I ask a question? It seems that |
|
Are there any specific use cases where false negatives are an issue? |
|
I don't currently have a specific use case in mind, and I just wanted to inquire if this change aligns with my current understanding 😅 |
koic
force-pushed
the
fix_a_false_positive_for_rails_redundant_active_record_all_method
branch
2 times, most recently
from
0db2236
to
93b2574
Compare
masato-bkn
reviewed
Sep 21, 2023
| @@ -127,12 +127,15 @@ class RedundantActiveRecordAllMethod < Base | |||
| without | |||
| ].to_set.freeze | |||
|
|
|||
| POSSIBLE_ENUMERABLE_BLOCK_METHODS = %i[any? find select].freeze | |||
There was a problem hiding this comment.
It seems like the following methods could also be added to POSSIBLE_ENUMERABLE_BLOCK_METHODS for the same reason. What do you think?
- none?
- one?
- sum
- count
koic
force-pushed
the
fix_a_false_positive_for_rails_redundant_active_record_all_method
branch
from
93b2574
to
049a40e
Compare
Resolves rubocop#1114 (comment) This PR fixes a false positive for `Rails/RedundantActiveRecordAllMethod` when using some `Enumerable`'s methods with block argument. e.g. `Enumerable#find` and `ActiveRecord::Base#find` have different arguments, So false positives can be prevented.
koic
force-pushed
the
fix_a_false_positive_for_rails_redundant_active_record_all_method
branch
from
049a40e
to
e586f7f
Compare
koic
deleted the
fix_a_false_positive_for_rails_redundant_active_record_all_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1114 (comment)
This PR fixes a false positive for
RedundantActiveRecordAllMethodwhen usingfindwith block argument.e.g.
Enumerable#findandActiveRecord::Base#findhave different arguments, So false positives can be prevented.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.