Migrate TargetRailsVersion
to the new requires_gem
RuboCop API
#1137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
TargetRailsVersion
to conditionally use therequires_gem
API when available (depending on the version of the base RuboCop gem). This has several advantages:rubocop-rails
depends onrubocop
(e.g. forRuboCop::Cop::Base
), and that's fine, but there's also a hidden reverse dependency, whererubocop
implicitly depends onrubocop-rails
.rubocop-rails
registers its minimum version requirements, andrubocop
knows how to understand those without needing to call back intorubcop-rails
.requires_gem
.gem_requirements
list, just like any other.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.If this is a new cop, consider making a corresponding update to the Rails Style Guide.