Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Nokogiri::HTML.parse and Nokogiri::HTML5.parse on Rails/ResponseParsedBody #1181

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

r7kamura
Copy link
Contributor

Since Rails 7.1, response.parse_body now supports Content-Type: text/html responses:

So, how about adding support for this in the Rails/ResponseParsedBody cop?


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic
Copy link
Member

koic commented Dec 1, 2023

I've left a few review comments, please integrate html5 into html.

@r7kamura
Copy link
Contributor Author

r7kamura commented Dec 7, 2023

Thanks for reviewing. It certainly has improved as the HTML and HTML5 logics has been put together 👍

@koic koic merged commit 2776841 into rubocop:master Dec 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants