Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1189] Fix false negatives for Rails/Pluck #1190

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

koic
Copy link
Member

@koic koic commented Nov 30, 2023

Fixes #1189.

This PR fixes false negatives for Rails/Pluck when using safe navigation method calls.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#1189.

This PR fixes false negatives for `Rails/Pluck`
when using safe navigation method calls.
@koic koic force-pushed the fix_false_negatives_for_rails_pluck branch from 8fd329e to 8c2d8db Compare November 30, 2023 08:23
@koic koic merged commit 9d5a223 into rubocop:master Dec 1, 2023
12 checks passed
@koic koic deleted the fix_false_negatives_for_rails_pluck branch December 1, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Rails/Pluck aware of safe navigation operator
1 participant