Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/WhereNot when using implicit receiver #1222

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

bquorning
Copy link
Contributor

Fix an exception in Rails/WhereNot when calling .where on an implicit receiver (e.g. inside model code).

Fixes #1221


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fix `Rails/WhereNot` which raised an exception when calling `.where` on an
implicit receiver (e.g. inside model code).
@bquorning bquorning requested a review from koic December 19, 2023 16:39
@koic koic merged commit b1a8c86 into master Dec 19, 2023
12 checks passed
@koic koic deleted the fix-where_not-for-implicit-receiver branch December 19, 2023 16:53
@koic
Copy link
Member

koic commented Dec 19, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/WhereNot raises an error
2 participants