Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1230] Fix a false positive for Rails/SaveBang if persisted? is checked on parenthesised expression. #1258

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

Earlopain
Copy link
Contributor

There are a few more cases I can think of that should potentially be handled, like

while (post = User.create(params).persisted?
  params = new_params
end

but I'd wait until someone actually complains. It doesn't look like very practical code to me.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…isted?` is checked on parenthesised expression.
@koic koic merged commit f5c378a into rubocop:master Mar 24, 2024
14 checks passed
@Earlopain Earlopain deleted the false-positive-for-rails-save-bang branch March 24, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants