Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rails/HttpStatus aware of Rails specific response assertions #1267

Merged
merged 1 commit into from
May 1, 2024

Conversation

tldn0718
Copy link
Contributor

@tldn0718 tldn0718 commented Apr 4, 2024

This PR makes the HttpStatus Cop aware of the Rails-specific assertions that test responses from Rails applications, such as assert_response and assert_redirect_to.

This Cop enforces a consistent method of specifying HTTP status in render, redirect_to, and head, either symbolic or numeric. However, it did not account for assert_response and assert_redirect_to used in testing, which also accepts HTTP status as a parameter in a manner consistent with those methods.

This PR ensures that the HttpStatus Cop can enforce a uniform way of specifying HTTP status in both application and testing code. Specifically, it addresses the previously possible inconsistency in specifying HTTP Status when using assert_response and assert_redirect_to.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@tldn0718 tldn0718 changed the title Make Rails/HttpStatus award of Rails specific response assertions Make Rails/HttpStatus aware of Rails specific response assertions Apr 5, 2024
@koic koic merged commit 49b5fca into rubocop:master May 1, 2024
6 of 14 checks passed
@koic
Copy link
Member

koic commented May 1, 2024

Let's proceed with this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants