Make Rails/HttpStatus aware of Rails specific response assertions #1267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
HttpStatus
Cop aware of the Rails-specific assertions that test responses from Rails applications, such asassert_response
andassert_redirect_to
.This Cop enforces a consistent method of specifying HTTP status in
render
,redirect_to
, andhead
, either symbolic or numeric. However, it did not account forassert_response
andassert_redirect_to
used in testing, which also accepts HTTP status as a parameter in a manner consistent with those methods.This PR ensures that the
HttpStatus
Cop can enforce a uniform way of specifying HTTP status in both application and testing code. Specifically, it addresses the previously possible inconsistency in specifying HTTP Status when usingassert_response
andassert_redirect_to
.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.