Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1278] Fix a false positivie for Rails/SkipsModelValidations #1279

Merged

Conversation

tldn0718
Copy link
Contributor

Fixes #1278.

This PR fixes a false positive for Rails/SkipsModelValidations when using insert or insert! with a safe navigator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@tldn0718 tldn0718 force-pushed the fix-skip-model-validation-safe-navigator branch from eaedb72 to 40d9dc3 Compare May 16, 2024 13:16
@koic koic merged commit 171e6de into rubocop:master May 17, 2024
14 checks passed
@koic
Copy link
Member

koic commented May 17, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for Rails/SkipsModelValidations on safe navigated String#insert
2 participants