[Fix #1283] Mark WhereRange as unsafe autocorrect

[fatkodima]

Fixes #1283.

[mark-young-atg]

Looks good to me, thanks @fatkodima

[koic]

Can you update instances where joins(:events) is used with where('end_at < ?', Time.zone.now) as shown below to be corrected to where(events: { end_at: ...Time.zone.now })?

From:

joins(:events).where('end_at < ?', Time.zone.now)

To:

joins(:events).where(events: { end_at: ...Time.zone.now })

While it makes sense for SafeAutoCorrect: false in general, in the case of #1283, it seems it can first be provided as a safe autocorrection:

[fatkodima]

This is not a right suggestion, because if the column is on the top level table and we use joins, suggesting joins(:events).where(events: { end_at: ...Time.zone.now }) now incorrectly attaches column to the wrong table.

So I would just mark this cop as unsafe autocorrect and not to try be smart here, because it will not work out.

[koic]

Ah, OK. Can you add example code to the @safety section and provide a bit more detail?

[koic]

Since it is not false positive but unsafe autocorrection, ideally, it would be preferable to provide example that allows users to manually correct to the right autocorrection 😃

[fatkodima]

Added an example to the @safety section.

[koic]

Thanks 👍