Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1340] Fix a false positive for Rails/WhereEquals when qualifying the database name #1341

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Aug 26, 2024

And Rails/WhereNot/Rails/WhereRange as well. Fixes #1340

I'd like to extract some of this logic to a module sometime since it is looking rather similar.

The original issue mentions Redshift, and I know that MSSQL allows cross-database queries as well


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…qualifying the database name

And `Rails/WhereNot`/``Rails/WhereRange` as well.

I'd like to extract some of this logic to a module sometime since it is looking rather similar.

The original issue mentions Redshift, and I know that MSSQL allows cross-database queries as well
@koic koic merged commit 4c1b7d7 into rubocop:master Aug 27, 2024
14 checks passed
@koic
Copy link
Member

koic commented Aug 27, 2024

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants