Change Rails/EnvLocal to handle negated conditions
#1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Oct 7, 2024
| @@ -0,0 +1 @@ | |||
| * [#1373](https://github.com/rubocop/rubocop-rails/pull/1373): Change `Rails/EnvLocal` to handle negated conditions. ([@fatkodima][]) | |||
There was a problem hiding this comment.
Suggested change
| * [#1373](https://github.com/rubocop/rubocop-rails/pull/1373): Change `Rails/EnvLocal` to handle negated conditions. ([@fatkodima][]) | |
| * [#1374](https://github.com/rubocop/rubocop-rails/pull/1374): Change `Rails/EnvLocal` to handle negated conditions. ([@fatkodima][]) |
There was a problem hiding this comment.
Updated.
I wonder how that happened that #1373 is from 2018.
There was a problem hiding this comment.
Since that issue was transferred from rubocop/rubocop, it is not in chronological order.
fatkodima
force-pushed
the
env_local-handle-negations
branch
from
8ef1aa1
to
855e0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
EnvLocalcop does not detect!Rails.env.development? && !Rails.env.test?as an offense (!Rails.env.local?).I found a few such cases in my project.