Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #190] Fix Rails/SaveBang when return value is checked immediately #191

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

jas14
Copy link
Contributor

@jas14 jas14 commented Jan 22, 2020

Fixes #190.

Rails/SaveBang had a false positive when the return value of a create
call was checked directly with a call to persisted?.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@jas14 jas14 force-pushed the fix-savebang-immediate-check branch from 4e84e86 to eabb6be Compare January 22, 2020 19:26
@andyw8
Copy link
Contributor

andyw8 commented Jan 22, 2020

It's probably not essential, but this wouldn't cover the variant of return if object.create.new_record?.

@jas14
Copy link
Contributor Author

jas14 commented Jan 22, 2020

@andyw8 that's correct; I saw persisted? explicitly checked elsewhere, but no mention of new_record?. I think that should be a separate PR if applicable.

@koic
Copy link
Member

koic commented Jan 24, 2020

This looks good. Can you rebase with the latest master branch?

…mmediately

Fixes rubocop#190.

Rails/SaveBang had a false positive when the return value of a `create`
call was checked directly with a call to `persisted?`.
@jas14 jas14 force-pushed the fix-savebang-immediate-check branch from eabb6be to 340a54e Compare January 24, 2020 15:13
@koic koic merged commit 89f948e into rubocop:master Jan 24, 2020
@koic
Copy link
Member

koic commented Jan 24, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/SaveBang "use create! instead of create" false positive
3 participants