Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle undefined DidYouMean constants in UnknownEnv cop #297

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Handle undefined DidYouMean constants in UnknownEnv cop #297

merged 1 commit into from
Jul 21, 2020

Commits on Jul 21, 2020

  1. Handle undefined DidYouMean constants in UnknownEnv cop 

    The rubocop gem itself has a closed issue here:

rubocop/rubocop#7979

It details the fact that the DidYouMean constants are sometimes not
loaded even though the DidYouMean gem has been a part of Ruby since 2.3,
and should be required by default. The rubocop gem maintainers
determined this to be an upstream issue.

Here are some other relevant links to issues/PRs:

ruby/did_you_mean#117
rubocop/rubocop#8143

My solution is mostly a band-aid fix to handle this problem until it is
fixed - use the DidYouMean spell checker if it is defined, otherwise
skip spell checking if it is not.
    @taylorthurlow
    taylorthurlow committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    dde5636 View commit details
    Browse the repository at this point in the history