[Fix #310] Add EnforcedStyle to Rails/PluckInWhere
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_enforced_style_to_pluck_in_where
branch
from
090727f
to
285ff91
Compare
eugeneius
reviewed
Aug 2, 2020
| # `ActiveRecord::Relation` instance vs a call to `pluck` on an `Array` instance. | ||
| # | ||
| # Autocorrect is disabled by default for this cop since it may generate | ||
| # false positives. |
There was a problem hiding this comment.
Autocorrect is still enabled by default in this PR, did you mean to disable it too? I think changing the default enforced style to conservative is probably enough.
There was a problem hiding this comment.
You're quite right! This sentence is a forgotten copy-paste 💦 I update this PR.
Thank you for your review.
Fixes rubocop#310. This PR adds `EnforcedStyle` to `Rails/PluckInWhere`. By default, it does not register an offense if `pluck` method's receiver is a variable.
koic
force-pushed
the
add_enforced_style_to_pluck_in_where
branch
from
285ff91
to
0ddf3b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310.
This PR adds
EnforcedStyletoRails/PluckInWhere. By default, it does not register an offense ifpluckmethod's receiver is a variable.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.