Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #490] Make Rails/HttpStatus aware of head method #493

Merged

Conversation

koic
Copy link
Member

@koic koic commented May 22, 2021

Fixes #490.

This PR makes Rails/HttpStatus aware of head method.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the make_rails_http_status_aware_of_head_method branch from 210b4ad to df290bd Compare May 24, 2021 01:17
Fixes rubocop#490.

This PR makes `Rails/HttpStatus` aware of `head` method.
@koic koic force-pushed the make_rails_http_status_aware_of_head_method branch from df290bd to af973f2 Compare June 3, 2021 01:47
@koic koic merged commit cc15766 into rubocop:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Rails/HttpStatus aware of rendering with head
2 participants