Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set disabled by default for Rails/EnvironmentVariableAccess #505

Conversation

koic
Copy link
Member

@koic koic commented Jun 20, 2021

This PR sets disabled by default for Rails/EnvironmentVariableAccess.
The default status will be set to pending again when migration doc is written.
#442 (comment)


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This PR sets disabled by default for `Rails/EnvironmentVariableAccess`.
The default status will be set to `pending` again when migration doc is written.
rubocop#442 (comment)
@koic koic merged commit 20e03fb into rubocop:master Jun 21, 2021
@koic koic deleted the set_disabled_by_default_for_rails_environment_variable_access branch June 21, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant