Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Rails/ReflectionClassName when using class_name: to_s #509

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Fix an error for Rails/ReflectionClassName when using class_name: to_s #509

merged 1 commit into from
Jun 24, 2021

Conversation

skryukov
Copy link
Contributor

This PR fixes bug introduced in #471.

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@skryukov skryukov changed the title Fix Rails/ReflectionClassName raising an error when using class_name: to_s Fix an error for Rails/ReflectionClassName when using class_name: to_s Jun 23, 2021
@skryukov skryukov marked this pull request as ready for review June 23, 2021 10:21
@koic koic merged commit 41597b0 into rubocop:master Jun 24, 2021
@koic
Copy link
Member

koic commented Jun 24, 2021

Thanks!

@skryukov skryukov deleted the fix/reflection-class-name branch June 24, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants