Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmark AutoCorrect: false from Rails/UniqBeforePluck #580

Conversation

koic
Copy link
Member

@koic koic commented Nov 6, 2021

This AutoCorrect: false looks like it was set when there was no way to safe autocorrect by SafeAutocorrect: false.
Test code for the autocorrection exists. So it can be enabled by default. However, it is still unsafe because SafeAutocorrect: false.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This `AutoCorrect: false` looks like it was set when there was no way
to safe autocorrect by `SafeAutocorrect: false`.

Test code for the autocorrection exists. So it can be enabled by default.
However, it is still unsafe because `SafeAutocorrect: false`.
@@ -4940,10 +4940,6 @@ Model.distinct.pluck(:id)
| EnforcedStyle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side observation.

Examples are outdated, too.

# this will ~return a Relation~ that pluck is called on
Model.where(cond: true).pluck(:id).uniq

check:

> x=User.where('1 = 1').pluck(:id);
SELECT "users"."id" FROM "users" WHERE (1 = 1)
> x.class
=> Array

uniq will be called on an array.

# an association on an instance will ~return a CollectionProxy~
instance.assoc.pluck(:id).uniq

It will return an Array.

# good
Model.distinct.pluck(:id)

I understand the reasoning, but the usage of id breaks it.

Model.distinct.pluck(:favourite_food)

would make more sense.
I believe the usage of id in those examples is more confusing than helpful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. That point can open a PR separately. Can you open a PR if you like?

@koic koic merged commit b2b0e1b into rubocop:master Nov 10, 2021
@koic koic deleted the change_unmark_autocorrect_false_from_rails_uniq_before_pluck branch November 10, 2021 12:00
@pirj pirj mentioned this pull request Nov 10, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants