Add months and years to Rails/DurationArithmetic cop duration method set
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
agrobbin
force-pushed
the
duration-arithmetic-months-years
branch
from
21e9829
to
d14ca7d
Compare
koic
reviewed
Jan 12, 2022
changelog/fix_missing_duration_methods_for_rails_duration_arithmetic.md
Outdated
Show resolved
Hide resolved
agrobbin
force-pushed
the
duration-arithmetic-months-years
branch
from
d14ca7d
to
51afdbc
Compare
koic
reviewed
Jan 12, 2022
changelog/fix_missing_duration_methods_for_rails_duration_arithmetic.md
Outdated
Show resolved
Hide resolved
agrobbin
force-pushed
the
duration-arithmetic-months-years
branch
from
51afdbc
to
cb61c72
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
month(s)andyear(s)were inadvertently missed when implementationRails/DurationArithmetic, so I've added them here! I've also add some additional test coverage to ensure we are accounting for all of these duration arithmetic methods.