Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative for Rails/TransactionExitStatement #673

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Mar 17, 2022

#665 fixed a false positive when break is used in a block in transactions.
But it introduced a false negative on return or throw.

transaction do
  loop do
    break  # allowed
    return # should be detected
    throw  # should be detected
  end
end

This PR does not cover following false positive.
It's too complex to detect. And a bad code I believe (should be extracted to method).

transaction do
  catch :foo do
    throw :foo if condition1 # false positive -- just exit catch
    throw :bar if condition2 # true positive
  end
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@Tietew Tietew force-pushed the fix_a_false_negative_for_rails_transaction_exit_statement branch from 7310fe9 to 7327f97 Compare March 17, 2022 05:10
@koic koic merged commit d331c8d into rubocop:master Mar 17, 2022
@koic
Copy link
Member

koic commented Mar 17, 2022

This definitely advances the improvement step. Thank you!

@Tietew Tietew deleted the fix_a_false_negative_for_rails_transaction_exit_statement branch March 17, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants