Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #725] Fix an incorrect autocorrect for Rails/DotSeparatedKeys #726

Conversation

koic
Copy link
Member

@koic koic commented Jun 21, 2022

Fixes #725.

This PR fixes an incorrect autocorrect for Rails/DotSeparatedKeys when a key starts with dot.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…dKeys`

Fixes rubocop#725.

This PR fixes an incorrect autocorrect for `Rails/DotSeparatedKeys`
when a key starts with dot.
@koic koic merged commit e9a043d into rubocop:master Jun 25, 2022
@koic koic deleted the fix_an_incorrect_autocorrect_for_rails_dot_separated_keys branch June 25, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/DotSeparatedKeys autofix seems to keep all dots when combining the scope with the key.
1 participant