Fix a NoMethodError for errors.keys in a model
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for Rails/DeprecatedActiveModelErrorsMethods: - Fixed a NoMethodError on nil for `errors.keys` in a model. - Made the range calculation more exact so the replacement is easier. - Added missing correction assertions to most test cases. - Added missing test cases. - Improved test structure for future changes.
BrianHawley
force-pushed
the
fix_rails_deprecated_active_model_errors_methods_20220706_1
branch
from
b8afb46
to
aa9f790
Compare
9 tasks
BrianHawley
commented
Jul 6, 2022
| range = offense_range(node, receiver) | ||
| replacement = replacement(node, receiver) | ||
|
|
||
| corrector.replace(range, replacement) | ||
| end | ||
|
|
||
| def offense_range(node, receiver) | ||
| range_between(receiver.receiver.source_range.end_pos, node.source_range.end_pos) | ||
| receiver = receiver.receiver while receiver.send_type? && !receiver.method?(:errors) && receiver.receiver |
There was a problem hiding this comment.
Technically, for the current patterns, !receiver.method?(:errors) would be enough, but it seemed like a good idea to do the other checks in case new patterns are added. We don't want an infinite loop or bad method calls.
BrianHawley
commented
Jul 6, 2022
| it 'registers and corrects an offense when root receiver is a variable' do | ||
| expect_offense_if_model_file(<<~RUBY, file_path) | ||
| errors.keys | ||
| ^^^^^^^^^^^ Avoid manipulating ActiveModel errors as hash directly. |
There was a problem hiding this comment.
This is the specific case that caused the NoMethodError for me. I added the rest of the test changes to look for any other such errors.
|
@koic as requested. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for Rails/DeprecatedActiveModelErrorsMethods:
errors.keysin a model.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.