Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ActiveSupportExtensionsEnabled option by default #746

Conversation

koic
Copy link
Member

@koic koic commented Jul 13, 2022

Follow up rubocop/rubocop#10699.

ActiveSupportExtensionsEnabled option is supported since RuboCop 1.31.0. Please merge #729 first.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Follow up rubocop/rubocop#10699.

`ActiveSupportExtensionsEnabled` option is supported since RuboCop 1.31.0.
Please merge rubocop#729 first.
@koic koic merged commit c1d5cd7 into rubocop:master Jul 15, 2022
@koic koic deleted the enable_global_active_support_extensions_enabled_option branch July 15, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants