Add new Rails/DuplicateIgnoredColumns cop
#761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cop checks for duplicate calls to
`ActiveRecord::Base.ignore_columns=` as the subsequent calls will
override the first call.
Example:
# bad
class User < ApplicationRecord
self.ignored_columns = %w(profile)
self.ignored_columns = %w(birthday)
end
# good
class User < ApplicationRecord
self.ignored_columns = %w(profile birthday)
end
sikachu
force-pushed
the
avoid-duplicate-ignored-columns-cop
branch
from
dca42fd
to
4a71187
Compare
sikachu
changed the title
Rails/AvoidDuplicateIgnoredColumns cop
koic
reviewed
Sep 9, 2022
|
I think this cop can be provided an unsafe autocorrection. Do you plan to provide it in this PR? |
koic
reviewed
Sep 9, 2022
Sounds good! Let me take a look on how to implement it 😇 |
sikachu
changed the title
Rails/AvoidDuplicateIgnoredColumns copRails/DuplicateIgnoredColumns cop
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop checks for duplicate calls to
ActiveRecord::Base.ignored_columns=as the subsequent calls will override the first call.Example:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.