Add autocorrection for Rails/FilePath
#991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just merge #989. Can you rebase with the latest master branch and add a |
r7kamura
commented
Apr 25, 2023
Comment on lines
115
to
126
| context 'when using Rails.root called by double quoted string that ends with string interpolation' do | ||
| it 'registers an offense' do | ||
| expect_offense(<<~'RUBY') | ||
| "#{Rails.root}/a/#{b}" | ||
| ^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path/to')`. | ||
| RUBY | ||
|
|
||
| expect_correction(<<~'RUBY') | ||
| "#{Rails.root.join("a/#{b}")}" | ||
| RUBY | ||
| end | ||
| end |
There was a problem hiding this comment.
I've just merge #989. Can you rebase with the latest master branch and add a expect_correction test for that?
Thanks for the quick merge! Actually, I already have a test case for that here 👌
Anyway, I will rebase and try to resolve the conflict.
r7kamura
force-pushed
the
file-path-autocorrection
branch
from
30f4f0d
to
59f6f85
Compare
|
Thanks! |
This was referenced Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.