Add new RSpec/IdenticalEqualityAssertion cop

[tejasbubane]

Closes #1130

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

• Added the new cop to config/default.yml.
• The cop is configured as Enabled: pending in config/default.yml.
• The cop documents examples of good and bad code.
• The tests assert both that bad code is reported and that good code is not reported.
• Set VersionAdded in default/config.yml to the next minor version.

[pirj]

Since it's a new cop, do you mind to run it against https://github.com/pirj/real-world-rspec?
Usually, I remove all .rubocop.yml files in it manually. And each time I wish rubocop had an option to ignore config files in the source code.

Looks good in general.
Just a small note regarding the offence message and sanity check against popular repos using RSpec.

Thank you for another contribution!

[pirj]

Perfect. Thank you!

[tejasbubane]

@pirj I ran this cop on real-world-rspec and found these offenses:
https://gist.github.com/tejasbubane/e64636d7c7dd97c4b056a09b09a6c61b

[pirj]

@tejasbubane 99% look completely legit!

expect(true).to eq(true)

😆

Some are (rspec-core) testing the RSpec itself, but it's ok to flag them:

it("equality") { expect(1).to eq(1) }

The only one that is probably a false offence:

expect(fqdn_rand(3)).to eql(fqdn_rand(3))

Thank you!

BTW, did you feel the pain of removing .rubocop YAML files from that repo? 😄

[tejasbubane]

BTW, did you feel the pain of removing .rubocop YAML files from that repo?

No I ran with --only RSpec/IdenticalEqualityAssertion :)

[bquorning]

Good stuff. Only nitpick comments.

[tejasbubane]

@bquorning Thanks. Fixed as per your comments.

[pirj]

Thanks!

[pirj]

ran this cop on real-world-rspec and found these offenses:

BTW, did you feel the pain of removing .rubocop YAML files from that repo?

No I ran with --only RSpec/IdenticalEqualityAssertion :)

Do you mind sharing how you do it, @tejasbubane ?

~/source/rubocop-rspec $ rubocop --only RSpec/Rails/AvoidSetupHook ../real-world-rspec/
Error: RuboCop found unsupported Ruby version 2.4 in `TargetRubyVersion` parameter (in /Users/pirj/source/real-world-rspec/fat_free_crm/.rubocop.yml). 2.4-compatible analysis was dropped after version 1.12.
Supported versions: 2.5, 2.6, 2.7, 3.0, 3.1

same for real-world-rspec/camaleon-cms/.rubocop.yml
After removing them:

Error: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`.
(obsolete configuration found in /Users/pirj/source/real-world-rspec/rspec-mocks/.rubocop_rspec_base.yml, please update it)
The `Layout/IndentArray` cop has been renamed to `Layout/FirstArrayElementIndentation`.
(obsolete configuration found in /Users/pirj/source/real-world-rspec/rspec-mocks/.rubocop_rspec_base.yml, please update it)
The `Layout/IndentAssignment` cop has been renamed to `Layout/AssignmentIndentation`.
(obsolete configuration found in /Users/pirj/source/real-world-rspec/rspec-mocks/.rubocop_rspec_base.yml, please update it)
The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`.
(obsolete configuration found in /Users/pirj/source/real-world-rspec/rspec-mocks/.rubocop_rspec_base.yml, please update it)
The `Style/TrailingCommaInLiteral` cop has been removed. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in /Users/pirj/source/real-world-rspec/rspec-mocks/.rubocop_rspec_base.yml, please update it)
The `Style/MethodMissing` cop has been split into `Style/MethodMissingSuper` and `Style/MissingRespondToMissing`.
(obsolete configuration found in /Users/pirj/source/real-world-rspec/rspec-mocks/.rubocop_rspec_base.yml, please update it)

I have those one-liners handy:

fd --no-ignore --hidden 'rubocop*.yml' | xargs rm

and

for repo in $(fd --type d --maxdepth 1); do; (cd "$repo"; git reset --hard HEAD); done

But I'd rather run rubocop --only and skip those unrelated errors.

[tejasbubane]

@pirj Not sure how I ran with --only back then, but this worked when I tried now:

$ cat Gemfile     
source 'https://rubygems.org'

gem 'rubocop', path: '../rubocop'
gem 'rubocop-rspec', path: '../rubocop-rspec' # Contains newly built / unreleased cops

$ cat .rubocop.yml
require:
  - rubocop-rspec

AllCops:
  DisabledByDefault: true

RSpec/IdenticalEqualityAssertion:
  Enabled: true

$ bundle exec rubocop --config .rubocop.yml   
.....
54137 files inspected, 115 offenses detected

[pirj]

Thanks, that works!