Use Cop::Base API for ThreadSafety department
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#7 is required for the successful build. |
Follow rubocop/rubocop#7868. The legacy `Cop::Cop` API is soft deprecated and this PR use new `Cop::Base` API instead. > maintain any RuboCop extensions, as the legacy API will be removed in RuboCop 2.0. https://metaredux.com/posts/2020/10/21/rubocop-1-0.html This new API requires RuboCop 0.87 or higher. https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06 That dependent version update will be resolved in rubocop#7, so there are no updates in this PR.
koic
force-pushed
the
use_cop_base_api_for_performance_department
branch
from
bcaf05b
to
8cfb15d
Compare
bquorning
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rubocop/rubocop#7868.
The legacy
Cop::CopAPI is soft deprecated and this PR use newCop::BaseAPI instead.https://metaredux.com/posts/2020/10/21/rubocop-1-0.html
This new API requires RuboCop 0.87 or higher.
https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06
That dependent version update will be resolved in #7, so there are no updates in this PR.