Close pull request review #24791986 by removing specs supporting conn…

…ection reopen after it has been manually closed

Change ConnectionManuallyClosed exception name to ConnectionAlreadyClosed
Minor improvements

lib/bunny/exceptions.rb

@@ -97,9 +97,9 @@ def initialize(frame)
     end
   end
 
-  class ConnectionManuallyClosed < Exception
+  class ConnectionAlreadyClosed < Exception
     def initialize
-      super('Connection has been manually closed. Call #start to reopen it')
+      super('Connection has been already closed')
     end
   end
 

lib/bunny/session.rb

@@ -344,7 +344,7 @@ def transport_write_timeout
     # @return [Bunny::Channel] Newly opened channel
     def create_channel(n = nil, consumer_pool_size = 1, consumer_pool_abort_on_exception = false, consumer_pool_shutdown_timeout = 60)
       raise ArgumentError, "channel number 0 is reserved in the protocol and cannot be used" if 0 == n
-      raise ConnectionManuallyClosed if manually_closed?
+      raise ConnectionAlreadyClosed if manually_closed?
 
       @channel_mutex.synchronize do
         if n && (ch = @channels[n])
@@ -409,6 +409,7 @@ def closed?
       @status_mutex.synchronize { @status == :closed }
     end
 
+    # @return [Boolean] true if this AMQP 0.9.1 connection has been programmatically closed
     def manually_closed?
       @status_mutex.synchronize { @manually_closed == true }
     end

spec/issues/issue465_spec.rb

@@ -25,26 +25,7 @@
       it 'should raise an exception' do
         expect {
           connection.create_channel
-        }.to raise_error(Bunny::ConnectionManuallyClosed)
-      end
-    end
-
-    describe '#start' do
-      it 'should be possible to reopen it' do
-        connection.start
-        expect(connection.status).to eq :open
-      end
-    end
-
-    context 'and reopened' do
-      before :each do
-        connection.start
-      end
-
-      describe '#create_channel' do
-        it 'should create a new channel' do
-          expect(connection.create_channel).to be_kind_of(Bunny::Channel)
-        end
+        }.to raise_error(Bunny::ConnectionAlreadyClosed)
       end
     end
   end