Issue #549: Move connection to closed state when recovery attempts fail #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery attempts are exhausted When the RabbitMQ server goes down, the session attempts to continually reconnect, only stopping once the recovery_attempts threshold is met (or forever is this parameter is not provided). In the former case, there are no exceptions raised to indicate to clients that new messages are not being processed. This patch provides that by initiating close from the session, which will close related channels and the reader loop. Then, an exception will be thrown when subsequent operations are performed.
michaelklishin
approved these changes
Jul 28, 2018
|
This solution makes a lot of sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #549 for a more thorough description of the problem.
A gist:
When the RabbitMQ server goes down, the session attempts to continually
reconnect, only stopping once the recovery_attempts threshold is met (or
forever is this parameter is not provided). In the former case, there
are no exceptions raised to indicate to clients that new messages are
not being processed. This patch provides that by initiating close
from the session, which will close related channels and the reader
loop. Then, an exception will be thrown when subsequent operations are
performed.
Client code will now be able to rescue
Bunny::ConnectionClosedErrorto gracefully degrade.