Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix automatically_recover config option #605

Merged

Conversation

AlexNimoy
Copy link
Contributor

@AlexNimoy AlexNimoy commented Dec 17, 2020

If option automatically_recover: false and automatic_recovery not set

opts[:automatically_recover] || opts[:automatic_recovery] #=> nil
Other cases

false || nil #=> nil
nil || false #=> false

false | nil #=> false
nil | false #=> false

automatically_recover? return nil
https://github.com/ruby-amqp/bunny/blob/master/lib/bunny/session.rb#L456

# @return [Boolean] true if this connection has automatic recovery from network failure enabled
def automatically_recover?
  @automatically_recover
end

@michaelklishin michaelklishin merged commit 9b26b77 into ruby-amqp:master Feb 12, 2021
@michaelklishin
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants