Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.10 not working ? #258

Closed
optimum-dulopin opened this issue May 29, 2014 · 19 comments · Fixed by #260
Closed

0.6.10 not working ? #258

optimum-dulopin opened this issue May 29, 2014 · 19 comments · Fixed by #260

Comments

@optimum-dulopin
Copy link

Hi,
I've just updated to 0.6.10.
In development environment, it is working well, but in production, rails can't find any of my translations (for instance "translation missing: en.date.formats.long").
Did anything change since last version ?
I tried to visit ruby-i18n.org/wiki but it seems to be not working.

thanks

@arthurnn
Copy link
Contributor

Do you have any stacktrace? or any extra information you could provide to help us debug this?
also which version or ruby and rails are you using?

@carlosantoniodasilva
Copy link
Member

Please, as @arthurnn said, we need more information to try to reproduce the issue. I'll see if I can repro tomorrow, meanwhile please add as much info as possible here. Thanks.

It seems to be related to #238.

@ichylinux
Copy link

hi,

i have the same issue.
working on development mode but not on production mode

ruby: 2.0.0p451
rails: 3.2.18
i18n: 0.6.10

and i switch log level from :info to :debug and restart my rails app.
but no log about i18n is present. (only sql query and so on)

regards

@carlosantoniodasilva
Copy link
Member

I've just yanked the 0.6.10 version from rubygems while we figure out a fix or revert the offending commit. Meanwhile please revert back to 0.6.9. Thanks.

@arthurnn
Copy link
Contributor

Are you using the I18n.backend = I18n::Backend::Chain backend?

@ichylinux
Copy link

hi,

all i add to my raills app is in config/application.rb

config.i18n.available_locales = [:en, :ja]
config.i18n.enforce_available_locales = true
config.i18n.default_locale = :ja

arthurnn added a commit to arthurnn/i18n that referenced this issue May 29, 2014
Commit 12aa0f0 introduced a bug, where
if `Fallbacks` module is included in a class that doesnt define
`translations` the code would fail. This is a pretty common
scenario, for instance when the backend is a `Chain`. Also this was
pretty common case to fail in rails, as its include Fallbacks in the
I18n.backend, like this:
```
I18n.backend.class.send(:include, I18n::Backend::Fallbacks)
```

This stops using the `translations` method in the fallbacks, and instead
ignores `I18n::InvalidLocale` errors.

[fixes ruby-i18n#238]
[fixes ruby-i18n#258]
[fixes ruby-i18n#259]
@saarinen
Copy link

Can someone comment on why this gem was yanked rather than an update released?

@arthurnn
Copy link
Contributor

@saarinen , it was yanked because we got multiple people complaining about one error that were affecting the basic operation of the gem, the translate method. So the best solution was to yank the version until we find a stable fix for it.

@saarinen
Copy link

Wouldn't it be way less destructive to re-release 0.6.9 as 0.6.11?

@carlosantoniodasilva
Copy link
Member

I'm sorry, I don't see why, rolling back is pretty much the same work as bumping up, isn't it? Besides that, re-releasing 0.6.9 means people would expect what is in master to be in the released version, which could lead to more confusion.

Sorry about the trouble, we'll be releasing a new version with the fix soon.

@saarinen
Copy link

The issue is this: If I have a release pushing out to 40 production boxes, ten succeed, and then you yank the gem specified in my lock file, I now have 30 machines with failed releases and mismatched code in production. The only way to resolve this is get back on my development machine, manually uninstall the yanked version of the gem, bundle update, and start my release process from scratch. If you re-release the last known good version as an updated version, none of this disruption occurs.

To your point, if you yank the gem, you still have the issue where you have unreleased code in master.

Yanking a gem really should be reserved for the situation where the released gem is a security risk, and having even a single additional machine install it is not acceptable. This doesn't seem to be the case here, which is why it would be preferable to roll forward.

@carlosantoniodasilva
Copy link
Member

Right, this scenario is not a security risk indeed, but it's a completely broken app one, and we didn't want more people with broken apps in production. The scenario you're describing would require re-deploying one way or another if you had already deployed the new version, so I'm not sure what's the arguing here. We are working on it and should be fixed soon. Thanks for sharing your thoughts.

@carlosantoniodasilva
Copy link
Member

Can you guys try with current master and let us know whether it's working or you are still having issues? Thanks.

@ichylinux
Copy link

hi,

i tried with Gemfile

gem 'i18n', :git => 'https://github.com/svenfuchs/i18n.git'

and it is fine with both development mode and production mode.

thanks

@arthurnn
Copy link
Contributor

arthurnn commented Jun 2, 2014

❤️

@carlosantoniodasilva
Copy link
Member

Awesome, thank you for trying it and reporting back.

Carlos Antonio da Silva - via celular
On Jun 1, 2014 10:46 PM, "Arthur Nogueira Neves" [email protected]
wrote:

[image: ❤️]


Reply to this email directly or view it on GitHub
#258 (comment).

@waynerobinson
Copy link

Also, I believe that Bundler's new gem cache format doesn't support yanking anymore. Even though this has been yanked, a bundle install on my local machine (which knows about 0.6.10) was still locking the version in Gemfile.lock to 0.6.10.

Is my assumption correct @indirect?

[edit] Although maybe it's just because 0.6.10 was installed locally and so Bundler was using that to construct my Gemfile.lock.

@indirect
Copy link

if you're talking about bundler's upcoming new index format, yes, it will support yanks. it's not great, but not being able to yank is even worse.

@carlosantoniodasilva
Copy link
Member

Released 0.6.11 with current master fix, thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants