-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6.10 not working ? #258
Comments
Do you have any stacktrace? or any extra information you could provide to help us debug this? |
hi, i have the same issue. ruby: 2.0.0p451 and i switch log level from :info to :debug and restart my rails app. regards |
I've just yanked the 0.6.10 version from rubygems while we figure out a fix or revert the offending commit. Meanwhile please revert back to 0.6.9. Thanks. |
Are you using the |
hi, all i add to my raills app is in config/application.rb
|
Commit 12aa0f0 introduced a bug, where if `Fallbacks` module is included in a class that doesnt define `translations` the code would fail. This is a pretty common scenario, for instance when the backend is a `Chain`. Also this was pretty common case to fail in rails, as its include Fallbacks in the I18n.backend, like this: ``` I18n.backend.class.send(:include, I18n::Backend::Fallbacks) ``` This stops using the `translations` method in the fallbacks, and instead ignores `I18n::InvalidLocale` errors. [fixes ruby-i18n#238] [fixes ruby-i18n#258] [fixes ruby-i18n#259]
Can someone comment on why this gem was yanked rather than an update released? |
@saarinen , it was yanked because we got multiple people complaining about one error that were affecting the basic operation of the gem, the |
Wouldn't it be way less destructive to re-release 0.6.9 as 0.6.11? |
I'm sorry, I don't see why, rolling back is pretty much the same work as bumping up, isn't it? Besides that, re-releasing 0.6.9 means people would expect what is in master to be in the released version, which could lead to more confusion. Sorry about the trouble, we'll be releasing a new version with the fix soon. |
The issue is this: If I have a release pushing out to 40 production boxes, ten succeed, and then you yank the gem specified in my lock file, I now have 30 machines with failed releases and mismatched code in production. The only way to resolve this is get back on my development machine, manually uninstall the yanked version of the gem, bundle update, and start my release process from scratch. If you re-release the last known good version as an updated version, none of this disruption occurs. To your point, if you yank the gem, you still have the issue where you have unreleased code in master. Yanking a gem really should be reserved for the situation where the released gem is a security risk, and having even a single additional machine install it is not acceptable. This doesn't seem to be the case here, which is why it would be preferable to roll forward. |
Right, this scenario is not a security risk indeed, but it's a completely broken app one, and we didn't want more people with broken apps in production. The scenario you're describing would require re-deploying one way or another if you had already deployed the new version, so I'm not sure what's the arguing here. We are working on it and should be fixed soon. Thanks for sharing your thoughts. |
Can you guys try with current master and let us know whether it's working or you are still having issues? Thanks. |
hi, i tried with Gemfile
and it is fine with both development mode and production mode. thanks |
❤️ |
Awesome, thank you for trying it and reporting back. Carlos Antonio da Silva - via celular
|
Also, I believe that Bundler's new gem cache format doesn't support yanking anymore. Even though this has been yanked, a Is my assumption correct @indirect? [edit] Although maybe it's just because 0.6.10 was installed locally and so Bundler was using that to construct my |
if you're talking about bundler's upcoming new index format, yes, it will support yanks. it's not great, but not being able to yank is even worse. |
Released 0.6.11 with current master fix, thanks everyone. |
Hi,
I've just updated to 0.6.10.
In development environment, it is working well, but in production, rails can't find any of my translations (for instance "translation missing: en.date.formats.long").
Did anything change since last version ?
I tried to visit ruby-i18n.org/wiki but it seems to be not working.
thanks
The text was updated successfully, but these errors were encountered: