Improve performance on enforce_available_locales! #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,10 +41,18 @@ def available_locales | |||
| @@available_locales || backend.available_locales | |||
| end | |||
|
|
|||
| def available_locales_set | |||
| @@available_locales_set ||= available_locales.inject(Set.new) do |set, locale| | |||
There was a problem hiding this comment.
I decided to trade off space for performance in here, So I am adding 2 entries for each locale. (which should be super small anyways). Thus, we dont need to cast to string when looking up.
Cache the available_locales in a local Set, so we can lookup, and check for inclusions faster. [fixes ruby-i18n#230]
|
https://gist.github.com/arthurnn/10031665 gist to check the benchmark regression, and fix. |
|
IPS results: before the regression:(version 0.6.5) Calculating -------------------------------------
6809 i/100ms
-------------------------------------------------
77460.3 (±3.4%) i/s - 388113 in 5.017347safter the regression:(version 0.6.8) Calculating -------------------------------------
3484 i/100ms
-------------------------------------------------
37268.7 (±3.4%) i/s - 188136 in 5.054946safter this PR applied: Calculating -------------------------------------
6168 i/100ms
-------------------------------------------------
69042.9 (±3.3%) i/s - 345408 in 5.008701s |
thedarkone
added a commit
to thedarkone/i18n
that referenced
this pull request
Apr 14, 2014
The validity of config.locale is inforced in Config#locale=. Related ruby-i18n#230 and ruby-i18n#249.
thedarkone
added a commit
to thedarkone/i18n
that referenced
this pull request
Apr 18, 2014
The validity of config.locale is inforced in Config#locale=. Related ruby-i18n#230 and ruby-i18n#249.
carlosantoniodasilva
added a commit
that referenced
this pull request
May 7, 2014
Improve performance on enforce_available_locales!
|
Thanks @arthurnn ❤️ |
thedarkone
added a commit
to thedarkone/i18n
that referenced
this pull request
Jun 30, 2014
The validity of config.locale is inforced in Config#locale=. Related ruby-i18n#230 and ruby-i18n#249.
thedarkone
added a commit
to thedarkone/i18n
that referenced
this pull request
Jun 30, 2014
The validity of config.locale is inforced in Config#locale=. Related ruby-i18n#230 and ruby-i18n#249.
thedarkone
added a commit
to thedarkone/i18n
that referenced
this pull request
Jun 30, 2014
The validity of config.locale is inforced in Config#locale=. Related ruby-i18n#230 and ruby-i18n#249.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the available_locales in a local Set, so we can lookup, and check for inclusions faster.
[fixes #230]
review @carlosantoniodasilva