Dup string value when encoding if it is frozen #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String#encode! will raise a RuntimeError if the string instance is frozen. The normal string setter for required or optional string fields already dups the incoming string to avoid reference issues. However when the field is a repeated string field the assigned array is dup'ed, but ruby keeps any string's frozen state. The fix is simply to dup any string value when we go to encode if it is frozen.
|
This looks good to me. Out of curiosity, why use |
| def encode(value) | ||
| # TODO: make replace character configurable? | ||
| value = value.dup if value.frozen? | ||
| value.encode!(::Protobuf::Field::StringField::ENCODING, :invalid => :replace, :undef => :replace, :replace => "") | ||
| value.force_encoding(::Protobuf::Field::BytesField::BYTES_ENCODING) |
There was a problem hiding this comment.
What is the purpose of calling force_encoding after the call to encode! ?
There was a problem hiding this comment.
I guess the better question is why do we encode! it as UTF-8 before it is re-encoded as ASCII-8BIT, since it's encoded as UTF-8 on the receiving end anyway?
localshred
added a commit
that referenced
this pull request
Sep 6, 2013
Dup string value when encoding if it is frozen
|
I don't have any specific recommendations. Just trying to understand the differences... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String#encode! will raise a RuntimeError if the string instance is frozen.
The normal string setter for required or optional string fields already dups
the incoming string to avoid reference issues. However when the field is a
repeated string field the assigned array is dup'ed, but ruby keeps any
string's frozen state.
The fix is simply to dup any string value when we go to encode if it is
frozen.