Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unknown keyword arg from DateTime.parse #488

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

headius
Copy link
Contributor

@headius headius commented Dec 1, 2021

This snuck in while addding tests for the create_additions
feature. Caught by JRuby when we added the limit option to the
Date/DateTime parsing methods, which causes this to be rejected as
an unknown keyword.

This snuck in while addding tests for the `create_additions`
feature. Caught by JRuby when we added the `limit` option to the
Date/DateTime parsing methods, which causes this to be rejected as
an unknown keyword.
@headius
Copy link
Contributor Author

headius commented Dec 1, 2021

We opted to exclude this test in jruby/jruby@a9f3b6b because it started to fail when we added the limit option. JRuby's date library is still partially in Ruby, and adding the limit option there meant it started to reject unknown keywords, like `create_additions.

This was not found by CRuby because the option processing in CRuby's date library does not reject unknown keywords.

@hsbt hsbt merged commit 431317d into ruby:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants