Implement Pathname#chdir #33
Conversation
ext/pathname/pathname.c
Outdated
| { | ||
| VALUE args[1]; | ||
|
|
||
| if(rb_block_given_p()) { |
There was a problem hiding this comment.
Very Minor: is the if ( the style used in other conditionals in this file?
There was a problem hiding this comment.
Oh, indeed! Thank you for noticing.
zverok
force-pushed
the
feature-chdir
branch
from
01fc436
to
de4c140
Compare
|
|
|
@toy Interesting. Do you know the justification? (The obsoleting commit doesn't link to the tracker ticket or ruby-core email discussion) 🤔 |
|
@zverok I remember being frustrated about the change and that justification was something about the method being misplaced, but I failed now to find any more information about it |
|
@hsbt That one is about removal of methods already marked obsolete, but not why were they marked obsolete |
|
@hsbt Any updates on this?.. It is a bit weird now that (more simple) |
|
see #25 (comment) |
As it was introduced into Ruby 3.3 as
Dir#chdir, and was requested before that in #25.