Fix an incorrectly resolved arg pattern

ruby · Sep 27, 2019 · 00aacdc · 00aacdc
1 parent d8aba43
commit 00aacdc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/rake/task_manager.rb b/lib/rake/task_manager.rb
@@ -133,8 +133,8 @@ def resolve_args_with_dependencies(args, hash) # :nodoc:
         deps = value || []
       else
         task_name = args.shift
-        arg_names = key
-        deps = value
+        arg_names = key || args.shift|| []
+        deps = value || []
       end
       deps = [deps] unless deps.respond_to?(:to_ary)
       [task_name, arg_names, deps, order_only]

diff --git a/test/test_rake_task_manager_argument_resolution.rb b/test/test_rake_task_manager_argument_resolution.rb
@@ -8,9 +8,16 @@ def test_good_arg_patterns
     assert_equal [:t, [], [:x], nil],     task(t: :x)
     assert_equal [:t, [], [:x, :y], nil], task(t: [:x, :y])
 
+    assert_equal [:t, [], [], [:m]],           task(:t, order_only: [:m])
+    assert_equal [:t, [], [:x, :y], [:m, :n]], task(t: [:x, :y], order_only: [:m, :n])
+
     assert_equal [:t, [:a, :b], [], nil],       task(:t, [:a, :b])
     assert_equal [:t, [:a, :b], [:x], nil],     task(:t, [:a, :b] => :x)
     assert_equal [:t, [:a, :b], [:x, :y], nil], task(:t, [:a, :b] => [:x, :y])
+
+    assert_equal [:t, [:a, :b], [], [:m]],           task(:t, [:a, :b], order_only: [:m])
+    assert_equal [:t, [:a, :b], [:x], [:m]],         task(:t, [:a, :b] => :x, order_only: [:m])
+    assert_equal [:t, [:a, :b], [:x, :y], [:m, :n]], task(:t, [:a, :b] => [:x, :y], order_only: [:m, :n])
   end
 
   def task(*args)