Merge pull request #209 from ruby/frozen

Specify frozen string literal is true
ruby · Jun 20, 2017 · 06381f6 · 06381f6
2 parents 5d9bc4c + 23f779f
commit 06381f6
Show file tree

Hide file tree

Showing 94 changed files with 99 additions and 6 deletions.
diff --git a/doc/jamis.rb b/doc/jamis.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module RDoc
 module Page
 

diff --git a/lib/rake.rb b/lib/rake.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #--
 # Copyright 2003-2010 by Jim Weirich ([email protected])
 #

diff --git a/lib/rake/application.rb b/lib/rake/application.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "optparse"
 
 require "rake/task_manager"

diff --git a/lib/rake/backtrace.rb b/lib/rake/backtrace.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
   module Backtrace # :nodoc: all
     SYS_KEYS  = RbConfig::CONFIG.keys.grep(/(?:[a-z]prefix|libdir)\z/)

diff --git a/lib/rake/clean.rb b/lib/rake/clean.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The 'rake/clean' file defines two file lists (CLEAN and CLOBBER) and
 # two rake tasks (:clean and :clobber).
 #

diff --git a/lib/rake/cloneable.rb b/lib/rake/cloneable.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
   ##
   # Mixin for creating easily cloned objects.

diff --git a/lib/rake/cpu_counter.rb b/lib/rake/cpu_counter.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # Based on a script at:

diff --git a/lib/rake/default_loader.rb b/lib/rake/default_loader.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # Default Rakefile loader used by +import+.

diff --git a/lib/rake/dsl_definition.rb b/lib/rake/dsl_definition.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Rake DSL functions.
 require "rake/file_utils_ext"
 

diff --git a/lib/rake/early_time.rb b/lib/rake/early_time.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # EarlyTime is a fake timestamp that occurs _before_ any other time value.

diff --git a/lib/rake/ext/core.rb b/lib/rake/ext/core.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Module
   # Check for an existing method in the current class before extending.  If
   # the method already exists, then a warning is printed and the extension is

diff --git a/lib/rake/ext/string.rb b/lib/rake/ext/string.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake/ext/core"
 
 class String
@@ -136,7 +137,7 @@ def pathmap_replace(patterns, &block)
     # This String extension comes from Rake
     def pathmap(spec=nil, &block)
       return self if spec.nil?
-      result = ""
+      result = "".dup
       spec.scan(/%\{[^}]*\}-?\d*[sdpfnxX%]|%-?\d+d|%.|[^%]+/) do |frag|
         case frag
         when "%f"

diff --git a/lib/rake/file_creation_task.rb b/lib/rake/file_creation_task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake/file_task"
 require "rake/early_time"
 

diff --git a/lib/rake/file_list.rb b/lib/rake/file_list.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake/cloneable"
 require "rake/file_utils_ext"
 require "rake/ext/string"

diff --git a/lib/rake/file_task.rb b/lib/rake/file_task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake/task.rb"
 require "rake/early_time"
 

diff --git a/lib/rake/file_utils.rb b/lib/rake/file_utils.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rbconfig"
 require "fileutils"
 

diff --git a/lib/rake/file_utils_ext.rb b/lib/rake/file_utils_ext.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake/file_utils"
 
 module Rake

diff --git a/lib/rake/invocation_chain.rb b/lib/rake/invocation_chain.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # InvocationChain tracks the chain of task invocations to detect

diff --git a/lib/rake/invocation_exception_mixin.rb b/lib/rake/invocation_exception_mixin.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
   module InvocationExceptionMixin
     # Return the invocation chain (list of Rake tasks) that were in

diff --git a/lib/rake/late_time.rb b/lib/rake/late_time.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
   # LateTime is a fake timestamp that occurs _after_ any other time value.
   class LateTime

diff --git a/lib/rake/linked_list.rb b/lib/rake/linked_list.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # Polylithic linked list structure used to implement several data

diff --git a/lib/rake/loaders/makefile.rb b/lib/rake/loaders/makefile.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # Makefile loader to be used with the import file loader.  Use this to

diff --git a/lib/rake/multi_task.rb b/lib/rake/multi_task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # Same as a regular task, but the immediate prerequisites are done in

diff --git a/lib/rake/name_space.rb b/lib/rake/name_space.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 ##
 # The NameSpace class will lookup task names in the scope defined by a
 # +namespace+ command.

diff --git a/lib/rake/packagetask.rb b/lib/rake/packagetask.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Define a package task library to aid in the definition of
 # redistributable package files.
 

diff --git a/lib/rake/phony.rb b/lib/rake/phony.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Defines a :phony task that you can use as a dependency. This allows
 # file-based tasks to use non-file-based tasks as prerequisites
 # without forcing them to rebuild.

diff --git a/lib/rake/private_reader.rb b/lib/rake/private_reader.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # Include PrivateReader to use +private_reader+.

diff --git a/lib/rake/promise.rb b/lib/rake/promise.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # A Promise object represents a promise to do work (a chore) in the

diff --git a/lib/rake/pseudo_status.rb b/lib/rake/pseudo_status.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   ##

diff --git a/lib/rake/rake_module.rb b/lib/rake/rake_module.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake/application"
 
 module Rake

diff --git a/lib/rake/rake_test_loader.rb b/lib/rake/rake_test_loader.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake"
 
 # Load the test files from the command line.

diff --git a/lib/rake/rule_recursion_overflow_error.rb b/lib/rake/rule_recursion_overflow_error.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # Error indicating a recursion overflow error in task selection.

diff --git a/lib/rake/scope.rb b/lib/rake/scope.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
   class Scope < LinkedList # :nodoc: all
 

diff --git a/lib/rake/task.rb b/lib/rake/task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake/invocation_exception_mixin"
 
 module Rake
@@ -320,7 +321,7 @@ def set_arg_names(args)
     # Return a string describing the internal state of a task.  Useful for
     # debugging.
     def investigation
-      result = "------------------------------\n"
+      result = "------------------------------\n".dup
       result << "Investigating #{name}\n"
       result << "class: #{self.class}\n"
       result <<  "task needed: #{needed?}\n"

diff --git a/lib/rake/task_argument_error.rb b/lib/rake/task_argument_error.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # Error indicating an ill-formed task declaration.

diff --git a/lib/rake/task_arguments.rb b/lib/rake/task_arguments.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   ##

diff --git a/lib/rake/task_manager.rb b/lib/rake/task_manager.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
 
   # The TaskManager module is a mixin for managing tasks.

diff --git a/lib/rake/tasklib.rb b/lib/rake/tasklib.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake"
 
 module Rake

diff --git a/lib/rake/testtask.rb b/lib/rake/testtask.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake"
 require "rake/tasklib"
 

diff --git a/lib/rake/thread_history_display.rb b/lib/rake/thread_history_display.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rake/private_reader"
 
 module Rake

diff --git a/lib/rake/thread_pool.rb b/lib/rake/thread_pool.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "set"
 
 require "rake/promise"

diff --git a/lib/rake/trace_output.rb b/lib/rake/trace_output.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
   module TraceOutput # :nodoc: all
 

diff --git a/lib/rake/version.rb b/lib/rake/version.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rake
   VERSION = "12.0.0"
 

diff --git a/lib/rake/win32.rb b/lib/rake/win32.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rbconfig"
 
 module Rake

diff --git a/test/helper.rb b/test/helper.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 $:.unshift File.expand_path("../../lib", __FILE__)
 
 require 'coveralls'

diff --git a/test/support/file_creation.rb b/test/support/file_creation.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module FileCreation
   OLDFILE = "old"
   NEWFILE = "new"

diff --git a/test/support/rakefile_definitions.rb b/test/support/rakefile_definitions.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module RakefileDefinitions
   include FileUtils
 

diff --git a/test/support/ruby_runner.rb b/test/support/ruby_runner.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module RubyRunner
   include FileUtils
 

diff --git a/test/test_private_reader.rb b/test/test_private_reader.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "rake/private_reader"
 

diff --git a/test/test_rake.rb b/test/test_rake.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRake < Rake::TestCase

diff --git a/test/test_rake_application.rb b/test/test_rake_application.rb
@@ -1,4 +1,4 @@
-#encoding: UTF-8
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakeApplication < Rake::TestCase
@@ -37,7 +37,7 @@ def test_display_exception_details
 
   def test_display_exception_details_bad_encoding
     begin
-      raise "El Niño is coming!".force_encoding("US-ASCII")
+      raise "El Niño is coming!".dup.force_encoding("US-ASCII")
     rescue => ex
     end
 

diff --git a/test/test_rake_application_options.rb b/test/test_rake_application_options.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 TESTING_REQUIRE = []

diff --git a/test/test_rake_backtrace.rb b/test/test_rake_backtrace.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "open3"
 

diff --git a/test/test_rake_clean.rb b/test/test_rake_clean.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "rake/clean"
 

diff --git a/test/test_rake_cpu_counter.rb b/test/test_rake_cpu_counter.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakeCpuCounter < Rake::TestCase

diff --git a/test/test_rake_definitions.rb b/test/test_rake_definitions.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "fileutils"
 

diff --git a/test/test_rake_directory_task.rb b/test/test_rake_directory_task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "fileutils"
 require "pathname"

diff --git a/test/test_rake_dsl.rb b/test/test_rake_dsl.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakeDsl < Rake::TestCase

diff --git a/test/test_rake_early_time.rb b/test/test_rake_early_time.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakeEarlyTime < Rake::TestCase

diff --git a/test/test_rake_extension.rb b/test/test_rake_extension.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "stringio"
 

diff --git a/test/test_rake_file_creation_task.rb b/test/test_rake_file_creation_task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "fileutils"
 

diff --git a/test/test_rake_file_list.rb b/test/test_rake_file_list.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "pathname"
 

diff --git a/test/test_rake_file_list_path_map.rb b/test/test_rake_file_list_path_map.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakeFileListPathMap < Rake::TestCase

diff --git a/test/test_rake_file_task.rb b/test/test_rake_file_task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "fileutils"
 require "pathname"

diff --git a/test/test_rake_file_utils.rb b/test/test_rake_file_utils.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "fileutils"
 require "stringio"

diff --git a/test/test_rake_functional.rb b/test/test_rake_functional.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "fileutils"
 require "open3"

diff --git a/test/test_rake_invocation_chain.rb b/test/test_rake_invocation_chain.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakeInvocationChain < Rake::TestCase

diff --git a/test/test_rake_late_time.rb b/test/test_rake_late_time.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakeLateTime < Rake::TestCase

diff --git a/test/test_rake_linked_list.rb b/test/test_rake_linked_list.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestLinkedList < Rake::TestCase

diff --git a/test/test_rake_makefile_loader.rb b/test/test_rake_makefile_loader.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "rake/loaders/makefile"
 

diff --git a/test/test_rake_multi_task.rb b/test/test_rake_multi_task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "thread"
 

diff --git a/test/test_rake_name_space.rb b/test/test_rake_name_space.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakeNameSpace < Rake::TestCase

diff --git a/test/test_rake_package_task.rb b/test/test_rake_package_task.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 require "rake/packagetask"
 

diff --git a/test/test_rake_path_map.rb b/test/test_rake_path_map.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("../helper", __FILE__)
 
 class TestRakePathMap < Rake::TestCase