Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current rake & 1.9.3 #230

Closed
MSP-Greg opened this issue Oct 6, 2017 · 2 comments
Closed

Current rake & 1.9.3 #230

MSP-Greg opened this issue Oct 6, 2017 · 2 comments

Comments

@MSP-Greg
Copy link

MSP-Greg commented Oct 6, 2017

I was looking at another gem's Travis, and there were issues with 1.9.3, and an (upgraded) rake was one of the dependencies.

Gemspec shows ruby >= 1.9.3, but it isn't tested with it. Sure its okay?
@hsbt
Copy link
Member

hsbt commented Oct 7, 2017

It prefers to update >= 2.0.0 on gemspec.

rickhull added a commit to rickhull/rake that referenced this issue Nov 6, 2017
@rickhull
update required_ruby_version to 2.0.0
4135948 
- as suggested by @hsbt in issue ruby#230 on github
- problems with 1.9.3 have been reported, which is long EOL'd
@rickhull rickhull mentioned this issue Nov 6, 2017
Merged
@rickhull
Copy link
Contributor

rickhull commented Nov 6, 2017

It would be good to have an example, if not a test case for this. Still, I created a PR #236 per @hsbt's suggestion.

@hsbt hsbt closed this as completed Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hsbt @rickhull @MSP-Greg