Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old release notes as the maintenance policy has changed. #124

Merged
merged 4 commits into from
Mar 31, 2016
Merged

Remove old release notes as the maintenance policy has changed. #124

merged 4 commits into from
Mar 31, 2016

Conversation

satoryu
Copy link
Contributor

@satoryu satoryu commented Mar 25, 2016

Old documents sometimes make developers and users confusing like #123 . If the maintainer made a decision they will never provide release notes under doc/release_notes and provide History.rdoc instead, the old release notes should be removed.

CC: @hsbt @AknEp

@drbrain
Copy link
Member

drbrain commented Mar 25, 2016

We can't remove old release notes because it makes it harder to find when a bug was introduced.

Merging old-style release notes into History.rdoc would be OK.

@zzak
Copy link
Member

zzak commented Mar 26, 2016

As an alternative, we could put a README in this directory which explains the current policy for release notes.

@hsbt
Copy link
Member

hsbt commented Mar 27, 2016

I want to merge doc/release_notes and History.rdoc. After that I will merge this pull request.

@satoryu
Copy link
Contributor Author

satoryu commented Mar 28, 2016

Thank you for your replies.

@drbrain @hsbt ok, give me time to merge the old release notes into History.rdoc.

@zzak good idea it would work! btw, I don't know the current policy the maintainers made. Can I hand over it to the maintainers?

@satoryu
Copy link
Contributor Author

satoryu commented Mar 28, 2016

I've merged all release notes into History.rdoc (as I removed some part such as What is Rake) and put README.md in the directory doc/release_notes to tell visitors they should see History.rdoc.

omg, failed...
Do you have any idea to fix it?

@hsbt
Copy link
Member

hsbt commented Mar 28, 2016

I invoke failing test again. It works.

@satoryu
Copy link
Contributor Author

satoryu commented Mar 30, 2016

Please have a look through the PR again when you have time. @zzak @drbrain

@hsbt hsbt merged commit 491b530 into ruby:master Mar 31, 2016
@hsbt
Copy link
Member

hsbt commented Mar 31, 2016

@satoryu Thank you for your work!

@satoryu satoryu deleted the remove_old_release_notes branch March 31, 2016 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants