Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment parsing rules #134

Merged
merged 2 commits into from
May 16, 2016
Merged

Update comment parsing rules #134

merged 2 commits into from
May 16, 2016

Conversation

leethomas
Copy link
Contributor

@leethomas leethomas commented May 15, 2016 •
edited
Loading

Closes #106. Also makes first_sentence lookout for exclamation marks. For example:

# task name is testing
desc "This drops your database! Make sure you've backed up your db."

Running rake -T will show
rake testing # This drops your database

@hsbt
Copy link
Member

hsbt commented May 16, 2016

Thanks! I have no concerns to your patch.

@hsbt hsbt merged commit f67c571 into ruby:master May 16, 2016
@esotericpig esotericpig mentioned this pull request Apr 17, 2020
Closed
@kachick kachick mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leethomas @hsbt