Rake::TaskArguments#key? alias of #has_key?

[pda]

This PR adds Rake::TaskArguments#key?(key) as an alias of has_key?(key).

---

Rake::TaskArguments exposes a Hash-like interface including #has_key?(key), but is missing #key?(key). Making this worse, the method_missing behaviour means args.key?(:foo) does not raise NoMethodError, instead treating it like args[:key?] and generally returning nil.

The commonly referenced ruby-style-guide says:

Use Hash#key? instead of Hash#has_key? … As noted here by Matz, the longer forms are considered deprecated.

which links to matz saying:

"has_key" has already been deprecated by "key?"

RuboCop's Style/PreferredHashMethods rule complains about using has_key?:

lib/tasks/feed_consumer.rake:11:60: C: Use Hash#key? instead of Hash#has_key?.
    raise("task requires `interval` argument") unless args.has_key?(:interval)
                                                           ^^^^^^^^

However accepting its solution of using #key? causes silent failure via method_missing as described above.

[hsbt]

test fail with JRuby-9.1.5.0 is not related your pull request. I approved your patch. I will merge later.

[pda]

Thanks @hsbt, and thanks also for releasing v12.0.0 👍