Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the error message that tells users to list the tasks with rake --tasks #287

Merged
merged 1 commit into from
Nov 4, 2018

Conversation

colby-swandale
Copy link
Member

@colby-swandale colby-swandale commented Nov 2, 2018

This PR is reworking the error message when a given task does not exist.

$ rake foo
rake aborted!
Don't know how to build task 'foo' (see --tasks)
/Users/colby/.gem/ruby/2.5.1/gems/rake-12.3.1/exe/rake:27:in `<top (required)>'
(See full trace by running task with --trace)

There is a good opportunity here to reword the (see --tasks) into something more meaningful and direct.

Users may not be aware of the rake --tasks option, so this PR adjusts the error message to instead be direct in saying that you can see a list of available tasks using this command.

I've turned it into this, which i think provides better communication to users:

Don't know how to build task 'foo' (See the list of available tasks with `rake --tasks`)

@colby-swandale colby-swandale changed the title Rework the error message that tells to list the tasks with rake --tasks Rework the error message that tells users to list the tasks with rake --tasks Nov 2, 2018
@colby-swandale colby-swandale force-pushed the rework-invalid-task-error-message branch from 0086b4a to b6521cf Compare November 2, 2018 04:24
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.751% when pulling 0086b4a on colby-swandale:rework-invalid-task-error-message into 8e1ea2d on ruby:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.751% when pulling 0086b4a on colby-swandale:rework-invalid-task-error-message into 8e1ea2d on ruby:master.

@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage remained the same at 97.751% when pulling b6521cf on colby-swandale:rework-invalid-task-error-message into 8e1ea2d on ruby:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants