-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Rake on TruffleRuby #331
Conversation
One error on this run: https://github.com/ruby/rake/pull/331/checks?check_run_id=314340711
|
The issue seems to be that |
That's a trivial fix (use the main object in both cases), and then I can run all We'll need a nightly build of TruffleRuby to test in CI though, or skip that |
It's actually not the same In Ruby terms: wrap_module = Module.new
new_main = main.clone # make a copy of the singleton class and the methods there
new_main.extend(wrap_module) |
@eregon Thanks for your work. I'm okay to merge when CI was fixed. |
I just merged oracle/truffleruby@f054b32, which fixes |
and f19222f.
cc @hsbt